-
Notifications
You must be signed in to change notification settings - Fork 53
Update help messages of CLI commands #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 20s |
7319cae to
e209b0a
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
e209b0a to
226f993
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
226f993 to
47407d5
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
47407d5 to
93923d9
Compare
|
Build failed. ❌ pre-commit FAILURE in 1m 05s |
93923d9 to
1382e6a
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 08s |
1382e6a to
8c9ecb0
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 14s |
| --without_precommit Skip adding packit-specific pre-commit configuration | ||
| hook. | ||
| --force_precommit Create pre-commit configuration file if missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@betulependule I guess it got merged with the underscores anyways 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I completely missed these errors. 👀 I'll fix the other instances where dashes need to be replaced with underscores in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the underscores where intentional? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can push new commits to this PR, right? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's auto-generated, if you're going to adjust this specific section (the help for init), it will get overwritten next week anyways :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I took a look at the code and underscores are being used. 😅
I can make a new PR and change it in Packit to dashes if that would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better for the consistency with other options :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, tomorrow I'll make a new issue and fix it in Packit. 👍
8c9ecb0 to
cb6580a
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 11s |
cb6580a to
bbdaeb4
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 12s |
Automatically regenerated help messages for CLI command docs.